Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible background color for buttons and menu items #711

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

kiwiwong
Copy link
Collaborator

@kiwiwong kiwiwong commented Mar 11, 2022

简介

对按钮和菜单项背景颜色做兼容处理

Fixes #700

@kiwiwong kiwiwong added the bug Something isn't working label Mar 11, 2022
@kiwiwong kiwiwong requested a review from wewoor March 11, 2022 03:37
@kiwiwong kiwiwong self-assigned this Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #711 (baffd76) into main (091b658) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         189      189           
  Lines        5942     5942           
  Branches     1426     1426           
=======================================
  Hits         5427     5427           
  Misses        508      508           
  Partials        7        7           
Impacted Files Coverage Δ
src/services/theme/helper.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091b658...baffd76. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑在 perfectColorTheme 中做兼容处理

@kiwiwong kiwiwong changed the title fix: improve GitHub Plus theme colors fix: compatible background color for buttons and menu items Mar 11, 2022
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor added this to the 0.9.0-beta.5 milestone Mar 11, 2022
@wewoor wewoor merged commit a5134b0 into main Mar 11, 2022
@wewoor wewoor deleted the fix/themeColor branch March 11, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the Editor Menu display is incorrect
2 participants