Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sort in folderTree #524

Merged
merged 2 commits into from
Nov 30, 2021
Merged

feat: support sort in folderTree #524

merged 2 commits into from
Nov 30, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 文件夹树支持排序

主要变更

  • 在每次 setState 之前,sort 一下所有节点,节点排序按照,其中各个节点内部按照字母排序
├── 新建文件夹的输入框
├── 隐藏文件夹
├── 普通文件夹
├── 新建文件的输入框
├── 隐藏文件
└── 普通文件

@mortalYoung mortalYoung added the enhancement New feature or request label Nov 29, 2021
@mortalYoung mortalYoung self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #524 (51202b8) into main (14c6057) will increase coverage by 0.96%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   85.58%   86.55%   +0.96%     
==========================================
  Files         182      188       +6     
  Lines        5307     5496     +189     
  Branches     1189     1224      +35     
==========================================
+ Hits         4542     4757     +215     
+ Misses        758      729      -29     
- Partials        7       10       +3     
Impacted Files Coverage Δ
...c/services/workbench/explorer/folderTreeService.ts 99.39% <100.00%> (+0.08%) ⬆️
src/services/extensionService.ts 100.00% <0.00%> (ø)
stories/extensions/problems/index.tsx 75.00% <0.00%> (ø)
stories/extensions/data-sync/index.tsx 71.42% <0.00%> (ø)
stories/extensions/test/testPane.tsx 47.05% <0.00%> (ø)
stories/extensions/test/index.tsx 24.19% <0.00%> (ø)
stories/extensions/index.ts 100.00% <0.00%> (ø)
stories/extensions/locales-plus/index.tsx 80.00% <0.00%> (ø)
src/controller/search/search.tsx 96.84% <0.00%> (+2.10%) ⬆️
src/controller/explorer/editorTree.tsx 100.00% <0.00%> (+2.27%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c6057...51202b8. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 8802b1f into main Nov 30, 2021
@wewoor wewoor deleted the fix/foldertree-sort branch November 30, 2021 07:24
wewoor pushed a commit that referenced this pull request Dec 1, 2021
* feat: support sort in folderTree

* feat: improve check hidden files
wewoor added a commit that referenced this pull request Dec 6, 2021
* docs: update the introduction

* docs: update the Introduction of zhCN version

* docs: tutorials for keybinding, quickAccess and Icon

* feat: improve homepage (#527)

* build: update the limitation of node version (#515)

* fix: fix can't clear the notifications (#518)

* fix: fix can't clear the notifications

* test: update tests

* test: ignore render tests

* fix: fix create file node incorrect on contextMenu (#522)

* refactor:  optimize the MoleculeProvider (#517)

* refactor: update the MoleculeProvider

* fix(molecule provider): init workbench ui after init locales

* test: unit test for splitLanguagesExts

* docs: comments for MoleculeProvider

* test: unit test for MoleculeProvider

* refactor(i18n): update the apis of locales

* fix: correct the reset to rest

* chore: ignore website prettier

* style: prettify code

* test: update the snapshot case

* test: remove the snapshot

* test: update snapshot

* ci:  yarn test -u

* ci: remove the -u argument of yarn test

* test: update the MoleculeProvider snap

* fix: show the SubMenu in right place when the Menu is horizontal mode (#526)

* fix: show the submenu in right place when horizontal mode

* test: update the snap of Menu

* feat: support sort in folderTree (#524)

* feat: support sort in folderTree

* feat: improve check hidden files

* docs: update Guides

* docs: unify the files name

* docs: update Guides, Overview

* docs: update the QuickStart

* docs: update the first extension

* docs: update the extension guides

* docs: update Workbench UI

* fix: improve the circular dep error when execute yarn link (#528)

* fix: remove the warning in console (#529)

* fix: remove the warning in console

* test: update snapshots

* docs: update ColorTheme, readme, keybinding, i18n

* docs: update Keybinding

* docs: update quickAccess, add demo tips

* docs: update i18n

* docs: update Settings guide

* docs: update Icon guide

* docs: update customize the Workbench guide

* docs: update images

* docs: update Contributing

* docs: update English version

* fix: remove the 140 width limit for buttons

* docs: default locale is zh-CN

* docs: improve the links (#533)

Co-authored-by: 野迂迂 <[email protected]>
mortalYoung added a commit that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants