feat: develop a Split Pane component #509

mortalYoung · 2021-11-15T11:48:31Z

简介

开发 SplitPane 组件替代 react-split-pane

主要变更

新增 SplitPane 组件

请先合并 #510 的内容到本分支，再把本分支合并至 main 分支

Related Issues

Closed #644 #407

codecov · 2021-11-15T11:51:00Z

Codecov Report

Merging #509 (01a9de4) into main (e36b8ad) will increase coverage by 1.28%.
The diff coverage is 92.62%.

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   89.38%   90.66%   +1.28%     
==========================================
  Files         185      189       +4     
  Lines        5631     5915     +284     
  Branches     1336     1420      +84     
==========================================
+ Hits         5033     5363     +330     
+ Misses        590      545      -45     
+ Partials        8        7       -1

Impacted Files	Coverage Δ
src/services/theme/colorRegistry.ts	`100.00% <ø> (ø)`
src/services/theme/helper.ts	`100.00% <ø> (ø)`
src/controller/editor.tsx	`25.71% <40.00%> (+3.25%)`	⬆️
src/workbench/workbench.tsx	`71.15% <53.12%> (-28.85%)`	⬇️
src/services/workbench/editorService.ts	`96.73% <55.55%> (-1.39%)`	⬇️
src/workbench/editor/editor.tsx	`86.36% <75.00%> (ø)`
src/components/split/SplitPane.tsx	`97.43% <97.43%> (ø)`
src/components/collapse/index.tsx	`98.51% <98.30%> (+51.57%)`	⬆️
src/components/collapse/base.tsx	`100.00% <100.00%> (ø)`
src/components/split/base.ts	`100.00% <100.00%> (ø)`
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36b8ad...01a9de4. Read the comment docs.

src/components/split/SplitPane.tsx

wewoor · 2021-11-22T06:44:27Z

@mortalYoung 试了下，Workbench 面板 Resize 好像出不来，Outline 面板可以无限制拖动

mortalYoung · 2021-11-22T08:46:18Z

@mortalYoung 试了下，Workbench 面板 Resize 好像出不来，Outline 面板可以无限制拖动

resize 修复了，Panel 这块因为没有 minSize 和 maxSize 设置，所以可以无限制的拖动

wewoor

Not support the maxSize or 'minSize`

wewoor · 2021-11-22T11:18:06Z

@mortalYoung stories 中需要补充一个基本使用示例

* refactor: use built-in splitPane component in collapse and editor * feat: improve collapse * feat: support resize strategy for Split Pane * test: update tests * test: add unit tests for Collapse Component

mortalYoung · 2021-12-03T03:31:12Z

@mortalYoung stories 中需要补充一个基本使用示例

done！

wewoor

kiwiwong

调整panel的大小时，group的大小也会变。

kiwiwong

+1

src/components/split/style.scss

src/extensions/theme-defaults/themes/dark_defaults.json

wewoor

+1

mortalYoung added the feature label Nov 15, 2021

mortalYoung requested a review from wewoor November 15, 2021 11:48

mortalYoung self-assigned this Nov 15, 2021

mortalYoung mentioned this pull request Nov 15, 2021

refactor: use built-in splitPane component in collapse and editor #510

Merged

wewoor reviewed Nov 15, 2021

View reviewed changes

src/components/split/SplitPane.tsx Outdated Show resolved Hide resolved

mortalYoung force-pushed the feat/split branch from c24d7d3 to 47327d3 Compare November 18, 2021 08:59

mortalYoung changed the title ~~[WIP]: feat: develop a Split Pane component~~ feat: develop a Split Pane component Nov 18, 2021

wewoor requested changes Nov 22, 2021

View reviewed changes

wewoor changed the title ~~feat: develop a Split Pane component~~ WIP: feat: develop a Split Pane component Nov 22, 2021

mortalYoung force-pushed the feat/split branch from f46ef27 to 43853ee Compare December 1, 2021 02:25

mortalYoung added 15 commits December 2, 2021 19:21

feat: develop a Split Pane component

c90b2f2

feat: improve Split

be95b65

feat: support to set resize strategy for panes

0e2c512

test: add unit tests for SplitPane

0ff7b0c

feat: add exports in components/index

989e195

test: update tests

2d5fdd6

refactor: use built-in splitPane component in collapse and editor (#510)

ce8ad43

* refactor: use built-in splitPane component in collapse and editor * feat: improve collapse * feat: support resize strategy for Split Pane * test: update tests * test: add unit tests for Collapse Component

fix: editor cannot resize

a5b7d08

test: update snapshots

91a3a6f

feat: support to set minSize and maxSize

374a576

feat: support maxSize and minSize in Pane

06cc807

feat: improve Split

7148b30

test: fix circular dependency

09f4ae8

test: update tests

29b3782

test: update snapshots

4888356

mortalYoung force-pushed the feat/split branch from a2d600b to 4888356 Compare December 2, 2021 11:26

docs: add Split component stories

4948f3c

wewoor mentioned this pull request Feb 21, 2022

The Molecule Roadmap 2022 #607

Closed

14 tasks

mortalYoung added 3 commits February 21, 2022 11:55

Merge remote-tracking branch 'origin/main' into feat/split

118a89a

fix: improve the mouse move function in SplitPane

7607618

test: update tests

f161cbb

mortalYoung changed the title ~~WIP: feat: develop a Split Pane component~~ feat: develop a Split Pane component Feb 21, 2022

mortalYoung added 2 commits February 23, 2022 10:44

fix: replace react-split-pane in editor group

532a8a0

test: update tests

e5b1a1b

mortalYoung requested a review from wewoor February 23, 2022 02:53

wewoor requested a review from kiwiwong February 23, 2022 03:18

wewoor reviewed Feb 23, 2022

View reviewed changes

fix: fix the first editor in group can resize

74ebf30

mortalYoung requested a review from wewoor February 23, 2022 06:42

kiwiwong reviewed Feb 23, 2022

View reviewed changes

mortalYoung added 2 commits February 23, 2022 16:38

fix: fix unrelated size changed will trigger resize

e6a8672

test: update tests

1f62f3f

mortalYoung requested a review from kiwiwong February 23, 2022 08:53

mortalYoung linked an issue Feb 23, 2022 that may be closed by this pull request

The Collapse component refactoring #407

Closed

fix: improve resize stratygy on editor groups

09a80ab

kiwiwong approved these changes Feb 23, 2022

View reviewed changes

wewoor reviewed Feb 24, 2022

View reviewed changes

src/components/split/style.scss Outdated Show resolved Hide resolved

src/extensions/theme-defaults/themes/dark_defaults.json Show resolved Hide resolved

mortalYoung added 2 commits February 24, 2022 10:41

fix: remove useless style

d90d872

fix: use focusBorder as the backup of sash.hoverBorder

01a9de4

wewoor approved these changes Feb 24, 2022

View reviewed changes

wewoor merged commit 3317aee into main Feb 24, 2022

wewoor deleted the feat/split branch February 24, 2022 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: develop a Split Pane component #509

feat: develop a Split Pane component #509

mortalYoung commented Nov 15, 2021 •

edited

Loading

codecov bot commented Nov 15, 2021 •

edited

Loading

wewoor commented Nov 22, 2021 •

edited

Loading

mortalYoung commented Nov 22, 2021

wewoor left a comment •

edited

Loading

wewoor commented Nov 22, 2021

mortalYoung commented Dec 3, 2021

wewoor left a comment

kiwiwong left a comment

kiwiwong left a comment

wewoor left a comment

feat: develop a Split Pane component #509

feat: develop a Split Pane component #509

Conversation

mortalYoung commented Nov 15, 2021 • edited Loading

简介

主要变更

Related Issues

codecov bot commented Nov 15, 2021 • edited Loading

Codecov Report

wewoor commented Nov 22, 2021 • edited Loading

mortalYoung commented Nov 22, 2021

wewoor left a comment • edited Loading

Choose a reason for hiding this comment

wewoor commented Nov 22, 2021

mortalYoung commented Dec 3, 2021

wewoor left a comment

Choose a reason for hiding this comment

kiwiwong left a comment

Choose a reason for hiding this comment

kiwiwong left a comment

Choose a reason for hiding this comment

wewoor left a comment

Choose a reason for hiding this comment

mortalYoung commented Nov 15, 2021 •

edited

Loading

codecov bot commented Nov 15, 2021 •

edited

Loading

wewoor commented Nov 22, 2021 •

edited

Loading

wewoor left a comment •

edited

Loading