Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for editorTree in workbench #386

Merged
merged 6 commits into from
Sep 3, 2021
Merged

Conversation

mortalYoung
Copy link
Collaborator

简介

  • editorTree 组件新增测试用例
  • editorTree 组件支持 onToolbarClick 事件
  • 优化组件内部逻辑
  • 由于 Sidebar 里面的东西挺多的,所以拆分成多个 PR 提交

主要变更

  • 新增 onToolbarClick 事件,支持订阅
  • 内部逻辑优化,在 Menu 上新增 role 属性方便定位,考虑下一个 PR 把 menu 的 role 属性添加到组件上,而不是每次测试的时候加

@mortalYoung mortalYoung added enhancement New feature or request unit test The PR is for the unit test mainly labels Sep 1, 2021
@mortalYoung mortalYoung added this to the 0.9.0-alpha.5 milestone Sep 1, 2021
@mortalYoung mortalYoung self-assigned this Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #386 (f1d16dd) into main (3066baa) will increase coverage by 1.38%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   76.72%   78.11%   +1.38%     
==========================================
  Files         176      176              
  Lines        4808     4815       +7     
  Branches     1039     1041       +2     
==========================================
+ Hits         3689     3761      +72     
+ Misses       1111     1046      -65     
  Partials        8        8              
Impacted Files Coverage Δ
src/model/workbench/explorer/editorTree.ts 80.00% <ø> (ø)
src/controller/explorer/editorTree.tsx 46.34% <50.00%> (+0.18%) ⬆️
...c/services/workbench/explorer/editorTreeService.ts 100.00% <100.00%> (ø)
src/workbench/sidebar/explore/editorTree.tsx 100.00% <100.00%> (+88.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3066baa...f1d16dd. Read the comment docs.

@wewoor wewoor requested a review from ProfBramble September 2, 2021 05:36
@mortalYoung mortalYoung mentioned this pull request Sep 2, 2021
53 tasks
Copy link
Contributor

@ProfBramble ProfBramble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung mortalYoung merged commit d43dee4 into main Sep 3, 2021
@mortalYoung mortalYoung deleted the test/editorTree branch September 3, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unit test The PR is for the unit test mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants