Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update the Scrollable component #380

Merged
merged 7 commits into from
Sep 1, 2021
Merged

refactor: update the Scrollable component #380

merged 7 commits into from
Sep 1, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Aug 30, 2021

Description

重构 Scrollable 组件

Changes

  • 新增 thumbStyle 属性,默认滚动条 border0
  • 针对 className isShowShadow thumbStyle trackStyle 自定义属性添加单元测试
  • 代码可读性优化

忽略Scrollable 部分原生逻辑测试

@wewoor wewoor added refactoring Refactor unit test The PR is for the unit test mainly labels Aug 30, 2021
@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Aug 30, 2021
@wewoor wewoor requested a review from mortalYoung August 30, 2021 11:43
@wewoor wewoor self-assigned this Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #380 (5d64332) into main (facc68a) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   65.83%   66.04%   +0.21%     
==========================================
  Files         176      176              
  Lines        4768     4780      +12     
  Branches     1030     1031       +1     
==========================================
+ Hits         3139     3157      +18     
+ Misses       1610     1604       -6     
  Partials       19       19              
Impacted Files Coverage Δ
src/components/scrollable/index.tsx 100.00% <100.00%> (+13.33%) ⬆️
test/utils.ts 100.00% <0.00%> (ø)
...c/services/workbench/explorer/editorTreeService.ts 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update facc68a...5d64332. Read the comment docs.

@wewoor wewoor mentioned this pull request Aug 30, 2021
53 tasks
src/components/scrollable/__tests__/scrollable.test.tsx Outdated Show resolved Hide resolved
src/components/scrollable/__tests__/scrollable.test.tsx Outdated Show resolved Hide resolved
src/components/scrollable/index.tsx Outdated Show resolved Hide resolved
src/components/scrollable/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 5895c8e into main Sep 1, 2021
@wewoor wewoor deleted the test/scrollable branch September 1, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor unit test The PR is for the unit test mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants