Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for notificationService #346

Merged
merged 2 commits into from
Aug 19, 2021
Merged

test: add test for notificationService #346

merged 2 commits into from
Aug 19, 2021

Conversation

mortalYoung
Copy link
Collaborator

Descriptions

  • add test for the notificationService
  • improve notifications for testing

@mortalYoung mortalYoung mentioned this pull request Aug 19, 2021
53 tasks
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #346 (b09a960) into main (22597b4) will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   52.95%   53.67%   +0.72%     
==========================================
  Files         173      173              
  Lines        4604     4609       +5     
  Branches     1016     1016              
==========================================
+ Hits         2438     2474      +36     
+ Misses       2138     2110      -28     
+ Partials       28       25       -3     
Impacted Files Coverage Δ
src/services/notificationService.ts 100.00% <100.00%> (+90.62%) ⬆️
src/common/utils.ts 84.61% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22597b4...b09a960. Read the comment docs.

@mortalYoung mortalYoung added refactoring Refactor unit test The PR is for the unit test mainly labels Aug 19, 2021
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 66c135c into main Aug 19, 2021
@wewoor wewoor deleted the test/notifications branch August 19, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor unit test The PR is for the unit test mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants