-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update the ExtensionService APIs #342
Conversation
Add new APIs, includes getExtension, getAllExtensions, remove and reset so on methods; add comments for the IExtensionService interface
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 52.95% 56.05% +3.09%
==========================================
Files 173 173
Lines 4604 4626 +22
Branches 1016 1017 +1
==========================================
+ Hits 2438 2593 +155
+ Misses 2138 2007 -131
+ Partials 28 26 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Description
Refactor the ExtensionService and add unit tests for it.
Changes
getExtension
andgetAllExtensions
methodsextensions
property, only allow access by public methodsremove
methodreset
method for set the extensions to emptyIExtensionService
interfaceHow Has This Been Tested?
unit tests
for theExtensionService