-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: the Select and Option components #340
Conversation
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 50.43% 54.49% +4.05%
==========================================
Files 173 173
Lines 4596 4628 +32
Branches 1012 1020 +8
==========================================
+ Hits 2318 2522 +204
+ Misses 2250 2078 -172
Partials 28 28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Description
Refactor the Select and Option components, and add unit tests for them.
Changes
showArrow
getDerivedStateFromProps
method when the value changedonClick
event of Option, when set it isdisabled
, theonSelect
event of Select component will not be triggered