Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve workbench height & box-sizing #223

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix: improve workbench height & box-sizing #223

merged 1 commit into from
Jul 7, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 workbench 的高度问题,该问题会导致后续 collapse 计算高度出现误差。
  • 修复引入 antd 样式后,由于 ant-layout 会修改子节点的 box-sizing 导致出现样式误差

主要变更

  • workbench 设置高度,防止后续出现误差
  • 优化设置了 border-box 的以后的节点的样式
  • 由于 workbench 的高度设置了以后会比设置之前少一些,所以 global activity bar 的按钮的 padding 可以不需要设置了

@wewoor wewoor added this to the 0.9.0-alpha.3 milestone Jul 7, 2021
@wewoor wewoor merged commit 9f25dd5 into main Jul 7, 2021
@wewoor wewoor deleted the fix/style branch July 7, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants