refactor: use built-in splitPane component in collapse and editor #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortalYoung
changed the title
mortalYoung
force-pushed
the
refactor/split
branch
2 times, most recently
from
14250fa to
e522305
Compare
mortalYoung
force-pushed
the
feat/split
branch
from
c24d7d3 to
47327d3
Compare
mortalYoung
force-pushed
the
refactor/split
branch
from
89b4046 to
402ca89
Compare
mortalYoung
force-pushed
the
refactor/split
branch
from
402ca89 to
c9863ce
Compare
mortalYoung
changed the title
|
应该没问题了，先合并过去了 |
mortalYoung
added a commit
that referenced
this pull request
Dec 1, 2021
* refactor: use built-in splitPane component in collapse and editor * feat: improve collapse * feat: support resize strategy for Split Pane * test: update tests * test: add unit tests for Collapse Component
mortalYoung
added a commit
that referenced
this pull request
Dec 2, 2021
* refactor: use built-in splitPane component in collapse and editor * feat: improve collapse * feat: support resize strategy for Split Pane * test: update tests * test: add unit tests for Collapse Component
wewoor
pushed a commit
that referenced
this pull request
Feb 24, 2022
* feat: develop a Split Pane component * feat: improve Split * feat: support to set resize strategy for panes * test: add unit tests for SplitPane * feat: add exports in components/index * test: update tests * refactor: use built-in splitPane component in collapse and editor (#510) * refactor: use built-in splitPane component in collapse and editor * feat: improve collapse * feat: support resize strategy for Split Pane * test: update tests * test: add unit tests for Collapse Component * fix: editor cannot resize * test: update snapshots * feat: support to set minSize and maxSize * feat: support maxSize and minSize in Pane * feat: improve Split * test: fix circular dependency * test: update tests * test: update snapshots * docs: add Split component stories * fix: improve the mouse move function in SplitPane * test: update tests * fix: replace react-split-pane in editor group * test: update tests * fix: fix the first editor in group can resize * fix: fix unrelated size changed will trigger resize * test: update tests * fix: improve resize stratygy on editor groups * fix: remove useless style * fix: use focusBorder as the backup of sash.hoverBorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简介
主要变更
absolute布局的，所以拿到的 sizes 都是number类型，所以类型需要改成(number | string)[]，而 controller 直接面对组件的接口的数据类型改为numberdisplay:none来实现的，但该缺点会导致切换的时候，无法获取到高度，导致 collapse 的位置计算出现问题，需要大量的改动，不如直接讲 sidebar 的隐藏方式改为visibility