fix: improve the timing when to check empty of panels (#233)

DTStack · Jul 13, 2021 · 5ef6a82 · 5ef6a82
1 parent 088edd2
commit 5ef6a82
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/components/collapse/index.tsx b/src/components/collapse/index.tsx
@@ -93,6 +93,7 @@ export function Collapse(props: ICollapseProps) {
     }, []);
 
     React.useLayoutEffect(() => {
+        // It's necessary to check panel's empty before calculate every panel
         filterData.forEach((panel) => {
             const isActive = activePanelKeys.includes(panel.id);
             let isEmpty = true;
@@ -103,6 +104,9 @@ export function Collapse(props: ICollapseProps) {
                 isEmpty = !contentDom?.hasChildNodes();
             }
             panel._isEmpty = isEmpty;
+        });
+
+        filterData.forEach((panel) => {
             const [height, top] = calcPosition(
                 activePanelKeys,
                 panel,