Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoconnex reference features client #386

Closed
dblodgett-usgs opened this issue May 20, 2024 · 3 comments
Closed

geoconnex reference features client #386

dblodgett-usgs opened this issue May 20, 2024 · 3 comments

Comments

@dblodgett-usgs
Copy link
Collaborator

Need a basic client for geoconnex reference features.

Something like:

#' discover geoconnex reference feature layers
#' @return data.frame containing layers available and fields that are available to query.
discover_geoconnex_reference <- function() {}
#' get geoconnex reference feature layers
#' @return sf data.frame contianing requested reference features
get_geoconnex_reference <- function(AOI = NULL, ids = NULL, type = NULL, t_srs = NULL, buffer = 0.5) {
}
@ksonda
Copy link

ksonda commented May 21, 2024

backlog:

maybe allow fuzzy matching based on name, where name is whatever the json-ld context has mapped to schema:name.

@dblodgett-usgs
Copy link
Collaborator Author

Something I came across... it seems that the bbox filter is comparing feature bboxes rather than actual feature intersection?

When I request mainstems in a bbox for the area in the upper right here, I get way more rivers than I would expect.

image

@ksonda
Copy link

ksonda commented May 21, 2024

This would appear to be a pygeoapi issue, possibly at the top level of bbox, possibly with just the postgis provider, depending on what FGDC is backing its collections with.

https://geoapi.geoplatform.gov/collections/62e48e3e_c8e9_4d48_990b_44dbb8265dd0/items?bbox=-111.020099,44.956318,-110.953495,44.971865

from this bbox

image

dblodgett-usgs added a commit that referenced this issue May 23, 2024
initial implementation of geoconnex reference features for #386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants