Fix env checker single-step-env edge case (#1521) #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutogniew
force-pushed
the
feat/fix-envchecker-single-step-env
branch
from
00ebe6a to
9467ad6
Compare
Before this change, env checker failed to `reset()` the tested environment before calling `step()` when checking for `Inf` / `NaN`. This could cause environments which happened to have only one `step()` available before the episode was terminated to fail. This is now fixed.
lutogniew
force-pushed
the
feat/fix-envchecker-single-step-env
branch
from
9467ad6 to
c216f73
Compare
araffin
reviewed
May 25, 2023
araffin
reviewed
May 25, 2023
araffin
reviewed
May 25, 2023
araffin
reviewed
May 25, 2023
As suggested by Antonin Raffin <[email protected]>.
araffin
approved these changes
May 25, 2023
|
@araffin Thank you for the review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, env checker failed to
reset()the tested environment before callingstep()when checking forInf/NaN. This could cause environments which happened to have only onestep()available before the episode was terminated to fail.This is now fixed.
Motivation and Context
Closes #1521.
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line