-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v6r12] new ps and fk dfc #2200
Conversation
…nd add bulk replica and file insert
Very very nice! Not sure it should go to v6r12 though... This isn't patch material to me, it's a whole new set of features... |
Thanks :-) Totally agree about the patch remark, however we need this quickly, and it does not have, in principle, any impact on the existing systems |
for fileName in fileNames: | ||
lfn = "%s/%s" % ( directory, fileName ) | ||
lfn = lfn.replace( '//', '/' ) | ||
if not fileName: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 2 lines above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, you need to construct the lfn to use it later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if fileName is "" anyway you are not using the lfn but for failed dict, which... is it really useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. But if filename is not "", then we use the LFN later on. So I can probably replace it yes. But this part of the code is anyway a bit strange to me and I am not sure to fully understand it, which is why I did not want to change it too much :-)
Why can not it go to v6r13 ? |
As discussed in the build meeting mid December, it would be better in v6r12 for timing reasons |
This PR contains a new sql schema with enforced Foreign Key, as well as stored procedure. The managers to call the various PS are also included. It also contains numerous bug fixes