Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6r12] new ps and fk dfc #2200

Merged
merged 20 commits into from
Jan 20, 2015
Merged

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Dec 10, 2014

This PR contains a new sql schema with enforced Foreign Key, as well as stored procedure. The managers to call the various PS are also included. It also contains numerous bug fixes

@sposs
Copy link
Contributor

sposs commented Dec 10, 2014

Very very nice! Not sure it should go to v6r12 though... This isn't patch material to me, it's a whole new set of features...

@chaen
Copy link
Contributor Author

chaen commented Dec 10, 2014

Thanks :-) Totally agree about the patch remark, however we need this quickly, and it does not have, in principle, any impact on the existing systems

@chaen chaen changed the title Rel v6r12 new ps and fk dfc [v6r12] new ps and fk dfc Dec 12, 2014
for fileName in fileNames:
lfn = "%s/%s" % ( directory, fileName )
lfn = lfn.replace( '//', '/' )
if not fileName:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 2 lines above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, you need to construct the lfn to use it later on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if fileName is "" anyway you are not using the lfn but for failed dict, which... is it really useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. But if filename is not "", then we use the LFN later on. So I can probably replace it yes. But this part of the code is anyway a bit strange to me and I am not sure to fully understand it, which is why I did not want to change it too much :-)

@atsareg
Copy link
Contributor

atsareg commented Dec 15, 2014

Why can not it go to v6r13 ?

@chaen
Copy link
Contributor Author

chaen commented Jan 3, 2015

As discussed in the build meeting mid December, it would be better in v6r12 for timing reasons

atsareg pushed a commit that referenced this pull request Jan 20, 2015
@atsareg atsareg merged commit 6dc82cb into DIRACGrid:rel-v6r12 Jan 20, 2015
@chaen chaen deleted the rel-v6r12_NEW_PsAndFkDfc branch September 23, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants