Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manishdasa100/true note/feature #53

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

manishdasa100
Copy link
Contributor

Pull Request Checklist

Go through the check boxes given below and make sure you mark the relevant ones.

To check put x inside [ ] eg. [x] Extension

Is your project an

  • [x ] Extension
  • Application

Given below are the mandatory requirements we expect from your project. Your Pull Request will be reviewed only if all the minimum requirements relevant to your project are satisfied.

  • [ x] Added readme.md to my project folder with relevant information.
  • [x ] I have provided the demo video link (showing the functionality in action) or the public deployment link of my extension of application within the readme.md (if Applicable).
  • [ x] I have explained the process in a readable manner within readme.md.

Terms and Conditions

Plagiarism check from Team Crio will be solid and if your code is found to be plagiarized, the team has every right to reject your Pull Request and take necessary actions.

  • [x ] I can assure you that this is my own contribution and I did not involve in any kind of plagiarism activities.

Buckle up and wait till you recieve communication from the review team. Keep a tab on this pull request page for comments on your project. Any necessary suggestions will also be provide here. All the best :)

Once your PR get's merged, take some time ⏲️, celebrate 🥳 and share it with the community on slack.

Fixed the bug of reading undefined data from the memory when the extention is tried to use on a tab which was loaded before installing the extention
Changed let options to const options and let globals to const globals.
Changed const options to var options and const globals to var globals
Changed variable names to myOptions and myGlobals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant