-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require more gas compute for create denom instead of a cost #14
Conversation
Cc @larry0x - does this look correct to you? I can get this in to Juno v14 upgrade, then you can post your param change right after (I'll upstream to osmosis after I merge this) |
Cc @ethanfrey |
Lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
denom_creation_gas_consume was not registered properly when i tried to upgrade & set/get params. prob initGenesis Ill try again later. If not, pushing to v15 |
)" This reverts commit a25effd.
init
Per Larry's commonwealth thread: https://commonwealth.im/juno/discussion/10596-parameter-change-reduce-denom_creation_fee-to-zero
& CosmWasm#11
Is state breaking, so if we want this for v14, I need to run another upgrade on Uni next week with a temp handler, then backport to v14 upgrade handler
impl
denom_creation_gas_consume param added
If denom_creation_fee is nil, then denom_creation_gas_consume is used by adding extra gas consumption. This can be changed by governance at any time