Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require more gas compute for create denom instead of a cost #14

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

Reecepbcups
Copy link

@Reecepbcups Reecepbcups commented Mar 28, 2023

init

Per Larry's commonwealth thread: https://commonwealth.im/juno/discussion/10596-parameter-change-reduce-denom_creation_fee-to-zero

& CosmWasm#11

Is state breaking, so if we want this for v14, I need to run another upgrade on Uni next week with a temp handler, then backport to v14 upgrade handler

impl

denom_creation_gas_consume param added

"tokenfactory": {
      "params": {
        "denom_creation_fee": [],
        "denom_creation_gas_consume": "1000000"
      },
      "factory_denoms": []
    },

If denom_creation_fee is nil, then denom_creation_gas_consume is used by adding extra gas consumption. This can be changed by governance at any time

@Reecepbcups
Copy link
Author

Reecepbcups commented Mar 29, 2023

Cc @larry0x - does this look correct to you?

I can get this in to Juno v14 upgrade, then you can post your param change right after

(I'll upstream to osmosis after I merge this)

@Reecepbcups Reecepbcups changed the title [v15] Require more gas compute for create denom instead of a cost Require more gas compute for create denom instead of a cost Mar 29, 2023
@Reecepbcups Reecepbcups marked this pull request as ready for review March 29, 2023 17:11
@larry0x
Copy link

larry0x commented Mar 29, 2023

Cc @larry0x - does this look correct to you?

I can get this in to Juno v14 upgrade, then you can post your param change right after

(I'll upstream to osmosis later today)

Cc @ethanfrey

@larry0x
Copy link

larry0x commented Mar 29, 2023

Lgtm

Copy link

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reecepbcups Reecepbcups merged commit a25effd into main Mar 31, 2023
@Reecepbcups Reecepbcups deleted the reece/create-fee-to-zero branch March 31, 2023 20:38
@Reecepbcups Reecepbcups restored the reece/create-fee-to-zero branch March 31, 2023 21:41
@Reecepbcups
Copy link
Author

Reecepbcups commented Mar 31, 2023

denom_creation_gas_consume was not registered properly when i tried to upgrade & set/get params. prob initGenesis

Ill try again later. If not, pushing to v15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants