Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wasmd sub messages via Burn Plugin #892

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Nov 21, 2023

ref: CosmWasm/wasmd#1735

The previous burn plugin used the wasmkeeper.WithMessageHandler feature. This overwrote all wasmvm sub-messages and only allowed the BurnCoin in.

This patch uses the WithMessageHandlerDecorator instead, then uses the nested type to support all other messages after, similar to mesh security here

  • Fixes subMsg misbehavior outline from parent issue
  • v1800alpha4 upgrade handler for Uni-6
  • updated to ictest v7.0.0 tag
  • write a test to validate the subMsg not found error does occur (wasmd ABCI code 20)

@Reecepbcups Reecepbcups changed the title fix wasmd sub messages fix wasmd sub messages via Burn Plugin Nov 21, 2023
Copy link
Contributor

@joelsmith-2019 joelsmith-2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Reecepbcups Reecepbcups merged commit c7f8966 into main Nov 21, 2023
25 checks passed
@joelsmith-2019 joelsmith-2019 deleted the reece/wasmd-fix-submsg branch February 2, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants