-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<DB as ReadonlyStorage>::get
treats empty values as missing keys
#56
Comments
I don't know if the storage backend can differentiate the two cases (zero/null handling in Go seems to be a big 🤯 and it does not get easier over FFI). But I think we should work towards supporting both cases. Then an application can choose to treat them as the same thing or not. |
This has been resolved in #67 . @webmaster128 @ethanfrey I think we can close this issue. |
Nice. Can you add "Closes #56" to into the PR description, to get the linking right? |
Sure, Done :) |
Modified url and fixed query contract
The signature of the
<DB as ReadonlyStorage>::get
method suggests that the method distinguishes missing keys from keys with empty values, but as you can see on line 33, it returnsNone
for empty keys. Looks like len=0 is returned for missing keys as well (which makes sense).This is related to #55 .
The text was updated successfully, but these errors were encountered: