Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flickering benchmark tests #684

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix flickering benchmark tests #684

merged 1 commit into from
Nov 25, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 25, 2021

Resolves #659
The DB was blocking with a file handler some times.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #684 (cb7497c) into master (1da2078) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   60.21%   60.24%   +0.03%     
==========================================
  Files          48       48              
  Lines        5361     5361              
==========================================
+ Hits         3228     3230       +2     
+ Misses       1903     1902       -1     
+ Partials      230      229       -1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 88.25% <0.00%> (+0.34%) ⬆️

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ethanfrey ethanfrey merged commit 3580520 into master Nov 25, 2021
@alpe alpe deleted the 659-benchmarks branch November 25, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark tests flickering: directory not empty
2 participants