Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backport to main #2070

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix backport to main #2070

merged 3 commits into from
Dec 19, 2024

Conversation

chipshort
Copy link
Collaborator

Had to bump wasmvm again because I forgot to backport the fix there before releasing.

@chipshort chipshort requested a review from pinosu December 19, 2024 18:07
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.85%. Comparing base (3336848) to head (0b78484).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/keeper/keeper.go 64.28% 2 Missing and 3 partials ⚠️
x/wasm/keeper/wasmtesting/mock_engine.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
- Coverage   42.85%   42.85%   -0.01%     
==========================================
  Files          85       85              
  Lines       11587    11599      +12     
==========================================
+ Hits         4966     4971       +5     
- Misses       6180     6185       +5     
- Partials      441      443       +2     
Files with missing lines Coverage Δ
x/wasm/types/wasmer_engine.go 0.00% <ø> (ø)
x/wasm/keeper/wasmtesting/mock_engine.go 0.00% <0.00%> (ø)
x/wasm/keeper/keeper.go 77.46% <64.28%> (-0.15%) ⬇️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chipshort chipshort merged commit 96ae094 into main Dec 19, 2024
19 checks passed
@chipshort chipshort deleted the co/backport-fix branch December 19, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants