Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AcceptListGrpcQuerier concurrency issues #2065

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Dec 18, 2024

Resolves #2051

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.98%. Comparing base (c2b31e0) to head (00f9840).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/keeper/query_plugins.go 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
+ Coverage   42.85%   42.98%   +0.12%     
==========================================
  Files          85       85              
  Lines       11587    11589       +2     
==========================================
+ Hits         4966     4981      +15     
+ Misses       6180     6162      -18     
- Partials      441      446       +5     
Files with missing lines Coverage Δ
x/wasm/keeper/query_plugins.go 59.05% <50.00%> (+2.73%) ⬆️

@pinosu pinosu requested a review from chipshort December 18, 2024 16:47
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@pinosu pinosu force-pushed the 2051-fix_acceptlistgrpcquerier branch from 00f9840 to 5bd1483 Compare December 20, 2024 16:11
@pinosu pinosu merged commit 460b947 into main Dec 20, 2024
14 checks passed
@pinosu pinosu deleted the 2051-fix_acceptlistgrpcquerier branch December 20, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AcceptListGrpcQuerier is not concurrent-safe
2 participants