Fix temp dir creation #2018
Merged
Fix temp dir creation #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
Oct 28, 2024
| @@ -260,7 +260,6 @@ var tempDir = func() string { | |||
| if err != nil { | |||
| panic("failed to create temp dir: " + err.Error()) | |||
| } | |||
| defer os.RemoveAll(dir) | |||
There was a problem hiding this comment.
This defer call just immediately removed the folder after being created. This causes wasmvm to create the folder again and then it is never deleted. Over time that leads to a lot of temp folders accumulating when people run the cli.
What we actually want to do (and what is implemented in this PR) is to remove it after we are done with it.
pinosu
approved these changes
Oct 29, 2024
|
Sounds good. I added a comment. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
==========================================
+ Coverage 48.79% 48.81% +0.01%
==========================================
Files 65 65
Lines 10079 10079
==========================================
+ Hits 4918 4920 +2
+ Misses 4726 4725 -1
+ Partials 435 434 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2017
Looks like most chains copied this code for their wasmd integration.
We should probably inform them about this change.