Conditional migrate calling #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
7 times, most recently
from
5aa7844 to
f3dc1ac
Compare
chipshort
reviewed
Aug 27, 2024
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
3 times, most recently
from
ee10140 to
797cfa0
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
2 times, most recently
from
adda66f to
b8ebd23
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
017b75b to
7ad3f2e
Compare
2 tasks
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
7ad3f2e to
ad6dc5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
+ Coverage 48.79% 48.80% +0.01%
==========================================
Files 65 65
Lines 10079 10082 +3
==========================================
+ Hits 4918 4921 +3
Misses 4726 4726
Partials 435 435
|
|
I need to recompile the hackatom binaries to reduce the size |
|
Did you use the optimizer? |
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
ad6dc5b to
93289c1
Compare
I updated the binaries and used the optimizer, thanks! |
chipshort
reviewed
Nov 4, 2024
Comment on lines
+656
to
+676
| if instanceLevel == 1 { | ||
| return &wasmvmtypes.ContractResult{Ok: &wasmvmtypes.Response{}}, 0, nil | ||
| } | ||
| instanceLevel++ | ||
| submsgPayload := fmt.Sprintf(`{"sub":%d}`, instanceLevel) | ||
| return &wasmvmtypes.ContractResult{ | ||
| Ok: &wasmvmtypes.Response{ | ||
| Messages: []wasmvmtypes.SubMsg{ | ||
| { | ||
| ReplyOn: wasmvmtypes.ReplyNever, | ||
| Msg: wasmvmtypes.CosmosMsg{ | ||
| Wasm: &wasmvmtypes.WasmMsg{Migrate: &wasmvmtypes.MigrateMsg{ | ||
| ContractAddr: example1.Contract.String(), | ||
| NewCodeID: example2.CodeID, | ||
| Msg: []byte(submsgPayload), | ||
| }}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, 0, nil |
There was a problem hiding this comment.
nit: Could you deduplicate this? This code and the one for MigrateFn are identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.