Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger zone #1680

Closed
wants to merge 8 commits into from
Closed

danger zone #1680

wants to merge 8 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Oct 20, 2023

"hiiiiiiiiighway toooooo the daaaaaaaaaaannnnnnnggeeeeer zone!"

@alpe this PR began as a tweet about a v50 testnet with a live currency, between Simon and I.

But actually I think it will be useful to you guys because there were a few changes in the cmd folder, as often happens. Those changes are now made :).

@alpe
Copy link
Contributor

alpe commented Oct 20, 2023

Build fails: https://app.circleci.com/pipelines/github/CosmWasm/wasmd/4333/workflows/957615a3-43c2-44a0-a102-983b52efc085/jobs/20054

@faddat
Copy link
Contributor Author

faddat commented Oct 20, 2023

@alpe yeah I think you might actually want to merge this.

I had to do some of those typical updates from simapp that we frequently see, so it'll probably make it easier to support the final v50 release.

I'd meant this as more of a placeholder PR but it should be useful to you

@faddat faddat marked this pull request as ready for review October 20, 2023 17:50
@faddat faddat requested a review from alpe as a code owner October 20, 2023 17:50
@faddat
Copy link
Contributor Author

faddat commented Oct 20, 2023

@alpe you don't want to merge this, sorry. it uses an ibc with all of the field length patches, not the main branch.

@faddat faddat marked this pull request as draft October 20, 2023 17:51
This was referenced Oct 20, 2023
@faddat
Copy link
Contributor Author

faddat commented Oct 26, 2023

@alpe
Copy link
Contributor

alpe commented Nov 8, 2023

Thanks for the PR and pushing towards v50 support. The v0.50.1 release was tagged now that we can complete the work.
I am closing this now in favour of #1681 and #1696

@alpe alpe closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants