Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic address tests #1666

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Classic address tests #1666

merged 9 commits into from
Oct 13, 2023

Conversation

DariuszDepta
Copy link
Member

Added tests for BuildContractAddressClassic function.
And small spelling ;-)

@DariuszDepta DariuszDepta requested a review from pinosu October 12, 2023 13:34
@DariuszDepta DariuszDepta self-assigned this Oct 12, 2023
@DariuszDepta DariuszDepta requested a review from alpe as a code owner October 12, 2023 13:34
pinosu
pinosu requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! 💯
There are some small changes that would improve a bit the code, but very nice to have also some tests for the address generation.

x/wasm/keeper/addresses_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/addresses_test.go Outdated Show resolved Hide resolved
pinosu
pinosu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇
Just make the function private and then feel free to merge it!

x/wasm/keeper/addresses_test.go Outdated Show resolved Hide resolved
@pinosu pinosu mentioned this pull request Oct 13, 2023
Closed
@DariuszDepta DariuszDepta merged commit c8a6594 into main Oct 13, 2023
8 checks passed
@DariuszDepta DariuszDepta deleted the classic-address-tests branch October 13, 2023 08:02
@pinosu pinosu added the backport/v0.4x backport patches to sdk47 release branch label Oct 13, 2023
@mergify mergify bot mentioned this pull request Oct 13, 2023
Merged
pinosu pushed a commit that referenced this pull request Oct 13, 2023
@mergify @DariuszDepta
Classic address tests (backport #1666) (#1669)
981d438 
* Added tests for classic addresses.

(cherry picked from commit 1445baa)

* Used another prefix.

(cherry picked from commit d8fe3f9)

* Fixes.

(cherry picked from commit f79a694)

* Fixes.

(cherry picked from commit 29d10f3)

* Refactoring.

(cherry picked from commit 99ade09)

* Maybe this will fix the problem.

(cherry picked from commit 9394faf)

* Refactoring.

(cherry picked from commit 3af3036)

* Refactoring.

(cherry picked from commit 76f6f3d)

* Made cleanup function private.

(cherry picked from commit 257cd7e)

---------

Co-authored-by: Dariusz Depta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

@alpe alpe Awaiting requested review from alpe

Assignees

@DariuszDepta DariuszDepta

Labels
backport/v0.4x backport patches to sdk47 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszDepta @pinosu