Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system tests for chain upgrade #1643

Merged
merged 27 commits into from
Oct 13, 2023
Merged

Add system tests for chain upgrade #1643

merged 27 commits into from
Oct 13, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 29, 2023

Replaces #1561

@alpe alpe mentioned this pull request Sep 29, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #1643 (c18d088) into main (90d4368) will increase coverage by 0.15%.
Report is 11 commits behind head on main.
The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   56.62%   56.77%   +0.15%     
==========================================
  Files          62       62              
  Lines        8200     8232      +32     
==========================================
+ Hits         4643     4674      +31     
  Misses       3120     3120              
- Partials      437      438       +1
Files Coverage Δ
app/app.go 84.37% <100.00%> (+0.08%) ⬆️
app/upgrades.go 78.04% <78.94%> (+44.71%) ⬆️

@alpe alpe force-pushed the 1480-system_tests_chain_upgrade2 branch from 963e6a8 to 05552b7 Compare October 9, 2023 12:40
@alpe alpe mentioned this pull request Oct 9, 2023
Closed
@alpe alpe force-pushed the 1480-system_tests_chain_upgrade2 branch from 2fdd1a9 to 27b1c9a Compare October 9, 2023 14:05
@alpe alpe marked this pull request as ready for review October 10, 2023 12:48
@alpe alpe requested a review from pinosu October 10, 2023 12:48
pinosu
pinosu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM 👍

app/upgrades.go Show resolved Hide resolved
tests/system/cli.go Outdated Show resolved Hide resolved
tests/system/upgrade_test.go Show resolved Hide resolved
@alpe alpe merged commit cd78376 into main Oct 13, 2023
8 checks passed
@alpe alpe deleted the 1480-system_tests_chain_upgrade2 branch October 13, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu