Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty attribute values #1618

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Allow empty attribute values #1618

merged 3 commits into from
Nov 15, 2023

Conversation

99Kies
Copy link
Contributor

@99Kies 99Kies commented Sep 11, 2023 •
edited by alpe
Loading

Resolves #1617

@99Kies 99Kies requested a review from alpe as a code owner September 11, 2023 08:29
@99Kies 99Kies mentioned this pull request Sep 11, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #1618 (591fe3a) into main (09b5008) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   56.59%   56.60%   +0.01%     
==========================================
  Files          64       64              
  Lines        8755     8753       -2     
==========================================
  Hits         4955     4955              
+ Misses       3414     3413       -1     
+ Partials      386      385       -1
Files Changed Coverage Δ
x/wasm/keeper/events.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@alpe alpe added the spike Demo to showcase an idea. label Sep 14, 2023
@alpe alpe added backport/v0.4x backport patches to sdk47 release branch and removed spike Demo to showcase an idea. labels Oct 18, 2023
@alpe alpe mentioned this pull request Oct 18, 2023
Open
@alpe alpe changed the title remove event value judgment Allow empty attribute values Nov 15, 2023
alpe
alpe approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 💐
Nice work. The tests are also very much appreciated!

@alpe alpe merged commit 4e7316e into CosmWasm:main Nov 15, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@99Kies @mergify
Allow empty attribute values (#1618)
9ced765 
* remove event value judgment

* remove event value judgment

* fix cosmwasm events test

(cherry picked from commit 4e7316e)
@mergify mergify bot mentioned this pull request Nov 15, 2023
Merged
alpe added a commit that referenced this pull request Nov 15, 2023
@alpe
Merge pull request #1718 from CosmWasm/mergify/bp/releases/v0.4x/pr-1618
fa83464 
Allow empty attribute values (backport #1618)
This was referenced Jun 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
backport/v0.4x backport patches to sdk47 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why can't the value in add_attribute be “”?
2 participants
@99Kies @alpe