Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmvm 1.4 upgrade #1590

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Wasmvm 1.4 upgrade #1590

merged 9 commits into from
Sep 7, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 31, 2023

Resolves #1586

Includes

  • Wasmvm 1.4 upgrade
  • Dockerfile
  • Capabilty
  • Distribution queries

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first thoughts

x/wasm/keeper/testdata/contracts.go Outdated Show resolved Hide resolved
x/wasm/keeper/testdata/version.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1590 (b8b3bc9) into main (cb887ee) will increase coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is 90.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
+ Coverage   58.30%   58.48%   +0.18%     
==========================================
  Files          64       64              
  Lines        8643     8688      +45     
==========================================
+ Hits         5039     5081      +42     
- Misses       3194     3195       +1     
- Partials      410      412       +2     
Files Changed Coverage Δ
x/wasm/keeper/query_plugins.go 84.73% <90.56%> (+0.91%) ⬆️
app/wasm.go 100.00% <100.00%> (ø)

@alpe alpe requested a review from pinosu September 6, 2023 11:48
@alpe alpe changed the title Start wasmvm 1.4 upgrade Wasmvm 1.4 upgrade Sep 6, 2023
@alpe alpe marked this pull request as ready for review September 6, 2023 11:48
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -42,7 +43,7 @@ import (
//go:embed testdata/hackatom.wasm
var hackatomWasm []byte

const AvailableCapabilities = "iterator,staking,stargate,cosmwasm_1_1"
const AvailableCapabilities = "iterator,staking,stargate,cosmwasm_1_1,cosmwasm_1_2,cosmwasm_1_3,cosmwasm_1_4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
}

func TestDistributionQuery(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good tests!

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 👍

@alpe alpe merged commit 3d9d92c into main Sep 7, 2023
@alpe alpe deleted the 1586_wasmvm14 branch September 7, 2023 07:14
da1suk8 added a commit to da1suk8/wasmd that referenced this pull request Apr 3, 2024
This testdata based on CosmWasm#1590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to wasmvm 1.4
3 participants