Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: lint wasmd in the same manner as cosmos-sdk #1537

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 28, 2023

This PR updates linter settings in wasmd so that they exactly match those in the cosmos-sdk so that the style is
more consistent and less error prone.

@faddat faddat requested a review from alpe as a code owner July 28, 2023 09:37
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1537 (e3af9f8) into main (2d54a1d) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
+ Coverage   57.99%   58.03%   +0.03%     
==========================================
  Files          64       64              
  Lines        8633     8640       +7     
==========================================
+ Hits         5007     5014       +7     
- Misses       3213     3214       +1     
+ Partials      413      412       -1     
Files Changed Coverage Δ
app/ante.go 64.28% <ø> (ø)
app/test_support.go 0.00% <ø> (ø)
app/upgrades.go 74.00% <ø> (ø)
x/wasm/client/cli/gov_tx.go 13.05% <ø> (ø)
x/wasm/client/cli/new_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/query.go 0.00% <ø> (ø)
x/wasm/client/cli/utils.go 0.00% <ø> (ø)
x/wasm/ibc.go 68.36% <ø> (ø)
x/wasm/keeper/api.go 71.42% <ø> (ø)
x/wasm/keeper/events.go 100.00% <ø> (ø)
... and 37 more

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 👍

@pinosu pinosu merged commit 8627f85 into CosmWasm:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants