-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prune wasm codes proposal #1455
Closed
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f4b7fc0
Add prune wasm codes proposal
pinosu 821f632
Fix test
pinosu 6129f8b
Fix docs
pinosu 2cbb4fb
Add remove code method to wasmvm engine
pinosu 39c5442
Fix comments
pinosu b84c0f4
Add more tests
pinosu 6924b1b
Fix prune wasm codes method
pinosu 6baca9b
Fix test
pinosu b4dc69b
Fix integration test
pinosu 7ba798e
Fix bug and improve tests
pinosu 9ccd044
Rename latestCodeID and add more test cases
pinosu 77b129e
More testing
pinosu 6e2244e
Fix prune logic (#1460)
alpe ca4d1e6
Make tests more readable
pinosu 47b1326
Add simple bench test
pinosu 37b872e
Fix bench test
pinosu e7d4b32
Improve bench tests
pinosu 4dfc1f4
Increase timeout
pinosu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,7 +167,7 @@ func (m *MockWasmer) Unpin(checksum wasmvm.Checksum) error { | |
} | ||
|
||
func (m *MockWasmer) RemoveCode(checksum wasmvm.Checksum) error { | ||
if m.UnpinFn == nil { | ||
if m.RemoveCodeFn == nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
panic("not supposed to be called!") | ||
} | ||
return m.RemoveCodeFn(checksum) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start to get some numbers.
This runs with a mem db, tiny contracts and no duplicate instances. I can imagine disk IO can have some impact here but let's add another DB to compare them