Apply review feedback #1376
Merged
Apply review feedback #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
May 4, 2023
| @@ -133,7 +133,10 @@ func (k Keeper) OnRecvPacket( | |||
| res, gasUsed, execErr := k.wasmVM.IBCPacketReceive(codeInfo.CodeHash, env, msg, prefixStore, cosmwasmAPI, querier, ctx.GasMeter(), gas, costJSONDeserialization) | |||
| k.consumeRuntimeGas(ctx, gasUsed) | |||
| if execErr != nil { | |||
| panic(execErr) // let contract fully abort IBC receive in certain case | |||
| panic(execErr) // let the contract fully abort an IBC packet receive. | |||
|
Thanks for the feedback!
I need to backport the changes to main. I hope this is easier with a separate PR. |
alpe
added a commit
that referenced
this pull request
May 10, 2023
… (#1358) * Redesign IBC on packet recv error/ result.Err handling (cherry picked from commit 7cd5893) # Conflicts: # x/wasm/ibc.go # x/wasm/ibc_test.go # x/wasm/keeper/relay.go * Resolve conflicts * Apply review feedback (#1376) * Apply review feedback * Better test name * Add contract integration test * Better doc in test and minor refactoring --------- Co-authored-by: Alex Peters <[email protected]>
|
@Mergifyio backport main |
❌ No backport have been created
Git reported the following error: |
|
@Mergifyio backport main |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2023
* Apply review feedback * Better test name * Add contract integration test * Better doc in test and minor refactoring (cherry picked from commit 29481db)
alpe
added a commit
that referenced
this pull request
May 10, 2023
* Apply review feedback (#1376) * Apply review feedback * Better test name * Add contract integration test * Better doc in test and minor refactoring (cherry picked from commit 29481db) * Set correct test chain id --------- Co-authored-by: Alexander Peters <[email protected]>
larry0x
pushed a commit
to larry0x/wasmd
that referenced
this pull request
Jul 17, 2023
* add proto files * Update proto/osmosis/tokenfactory/v1beta1/authorityMetadata.proto Co-authored-by: Dev Ojha <[email protected]> * update comments on proto * add other types files * Apply suggestions from code review Co-authored-by: Aleksandr Bezobchuk <[email protected]> * update errors to not start from 1 * add more comments * add logic * update app setup * add back query * Apply suggestions from code review Co-authored-by: Aleksandr Bezobchuk <[email protected]> * add migration * Apply suggestions from code review Co-authored-by: Aleksandr Bezobchuk <[email protected]> * address comment * Apply suggestions from code review Co-authored-by: Roman <[email protected]> Co-authored-by: Dev Ojha <[email protected]> * Apply suggestions from code review Co-authored-by: Roman <[email protected]> * address comments * removed mintTo and burnFrom * fixed typo * fix comments * metadata Validate() function * fix stuff * add mint restriction * remove unused argument from NewMsgBurn() * x/tokenfactory: cli * fix extra arguments * address comments * Apply suggestions from code review Co-authored-by: Roman <[email protected]> * ? * params * tests * add params command Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Note: the ibc-reflect contract used is CosmWasm/cosmwasm#1685