Add wasm command to support v1 gov proposals #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
suggested changes
Apr 19, 2023
| return fmt.Errorf("authority: %s", err) | ||
| } | ||
|
|
||
| if len(authority) == 0 { |
There was a problem hiding this comment.
here and others: it would be nice if we would fetch the default authority like the wizard does. I would not expect the users to know the address.
alpe
reviewed
Apr 21, 2023
| @@ -57,7 +57,7 @@ func ValidateSalt(salt []byte) error { | |||
| // ValidateVerificationInfo ensure source, builder and checksum constraints | |||
| func ValidateVerificationInfo(source, builder string, codeHash []byte) error { | |||
| // if any set require others to be set | |||
| if len(source) != 0 || len(builder) != 0 || codeHash != nil { | |||
| if len(source) != 0 || len(builder) != 0 || len(codeHash) != 0 { | |||
alpe
approved these changes
Apr 21, 2023
x/wasm/client/cli/gov_tx.go
Outdated
| } | ||
|
|
||
| if len(authority) == 0 { | ||
| authority = sdk.AccAddress(address.Module("gov")).String() |
There was a problem hiding this comment.
I was expecting that the address would be queried but I guess it is alright to set it for the client already.
While the address can be changed in the keeper(s) on init, it can not be modified on the CLI. I have opened #1356 to have a public var instead. Please 👁️
Minor tweak and test files
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1301
Implemented option c) A new wasm command could provide a similar interface as v1beta1 proposals but with a v1 message send