Add missing TryFrom impls #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
changed the title
| @@ -270,12 +271,24 @@ impl Int128 { | |||
| } | |||
| } | |||
|
|
|||
| impl NumConsts for Int128 { | |||
| const ZERO: Self = Self::zero(); | |||
| const ONE: Self = Self::one(); | |||
There was a problem hiding this comment.
Any idea why zero() and one() are functions and not consts? Should this be changed for the public interface too?
There was a problem hiding this comment.
No idea why those are functions. I think using constants is more common, but it doesn't really make a difference. As far as I know, they can be used interchangeably.
There was a problem hiding this comment.
Looks like the standard library types don't have zero and one. So it does not matter much I guess.
webmaster128
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1863
I also ended up adding the rest of the missing unsigned to signed
TryFromimpls and signed to unsignedTryFromimpls because I needed some more for theSignedDecimalPR:Uint{64,128,256,512}->Int64Uint{128,256,512}->Int128Uint{256, 512}->Int256Uint512->Int512Int{64,128,256,512}->Uint{64,128,256,512}