Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl nth for External(Partial)Iterator #1838

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Impl nth for External(Partial)Iterator #1838

merged 2 commits into from
Aug 29, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1725

@chipshort chipshort requested a review from webmaster128 August 28, 2023 15:33
webmaster128
webmaster128 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I wish there was an easy way to test imports.rs but I don't know any

@webmaster128 webmaster128 mentioned this pull request Aug 28, 2023
Closed
@chipshort chipshort merged commit f8f9598 into main Aug 29, 2023
@chipshort chipshort deleted the 1725-skip-iterator branch August 29, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement skip for ExternalIterator
2 participants
@chipshort @webmaster128