Deprecate all cosmwasm-storage types #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
deprecate-cosmwasm-storage-types
branch
from
0858f89 to
1862505
Compare
webmaster128
commented
May 4, 2023
| pub const PREFIX_ACCOUNTS: &[u8] = b"accounts"; | ||
| /// Upper bound for ranging over accounts | ||
| const PREFIX_ACCOUNTS_UPPER_BOUND: &[u8] = b"accountt"; |
There was a problem hiding this comment.
Not for this PR, but it would be great to be able to calculate those things on demand with a well defined and well tested function. We do those things in a couple of places.
There was a problem hiding this comment.
Yes, there is namespace_upper_bound in storage and in storage-plus there's increment_last_byte and extend_one_byte (though all of them are private).
I just didn't want to copy that over for just this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1596