Increase dependency requirements to make -Zminimal-versions pass #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint
approved these changes
Oct 19, 2022
webmaster128
commented
Oct 19, 2022
packages/std/Cargo.toml
Outdated
| # to bump the min version of them. | ||
| bytecheck = "0.6.3" # With this version the simdutf8 dependency became optional | ||
| enumset = "1.0.2" # Fixes https://github.com/Lymia/enumset/issues/17 (https://github.com/Lymia/enumset/commit/a430550cd6a3c9b1ef636d37f75dede7616f5b62) | ||
| bitflags = "1.1.0" # https://github.com/CensoredUsername/dynasm-rs/pull/74 |
There was a problem hiding this comment.
This should move to cosmwasm-vm since it is only needed for wasmer and clap
webmaster128
commented
Oct 19, 2022
packages/std/Cargo.toml
Outdated
| uint = "0.9.3" | ||
|
|
||
| # Dependencies that we do not use ourself. We add those entries | ||
| # to bump the min version of them. | ||
| bytecheck = "0.6.3" # With this version the simdutf8 dependency became optional |
There was a problem hiding this comment.
This is well. A rkyv (wasmer) dependency
webmaster128
commented
Oct 19, 2022
packages/std/Cargo.toml
Outdated
| # Dependencies that we do not use ourself. We add those entries | ||
| # to bump the min version of them. | ||
| bytecheck = "0.6.3" # With this version the simdutf8 dependency became optional | ||
| enumset = "1.0.2" # Fixes https://github.com/Lymia/enumset/issues/17 (https://github.com/Lymia/enumset/commit/a430550cd6a3c9b1ef636d37f75dede7616f5b62) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change I the new
devtools/build_min.shpasses