Improve CanonicalAddr interoperability #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
CanonicalAddr-conversions
branch
from
1fe9a37 to
e6033ae
Compare
uint
reviewed
Oct 18, 2022
Comment on lines
+175
to
+180
| // Array reference | ||
| impl<const LENGTH: usize> From<&[u8; LENGTH]> for CanonicalAddr { | ||
| fn from(source: &[u8; LENGTH]) -> Self { | ||
| Self(source.into()) | ||
| } | ||
| } |
There was a problem hiding this comment.
You mean impl From<&[u8]> for CanonicalAddr? This was already implemented before a few lines above this addition.
Excellent question. Historically this has always been an unsafe newtype around Binary (with a public field), so at least this is not introducing any new unsafety. |
That's probably fine. I think Rust's |
uint
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #1456 and #1451