Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .wasm file extension to wasm files #1665

Closed
webmaster128 opened this issue Apr 19, 2023 · 0 comments · Fixed by #1686
Closed

Add .wasm file extension to wasm files #1665

webmaster128 opened this issue Apr 19, 2023 · 0 comments · Fixed by #1686
Assignees
Milestone

Comments

@webmaster128
Copy link
Member

It would be nice if .was. files had a .wasm file extension on disk to make the file tree easier to understand.

Before:

$ l ~/.noisd/wasm/wasm/state/wasm/
b8cc8ae4201ee757a70c1e6d8b72c3afb94fc36ba95294ab0614011069de0fe5
cb7b021831dd908b673491288b7a76f7ae973b8c1586ce41d9a69cadab5202c7
ddaca2d1887555ebfe07a65ebec09fd3a159e78c3c429de9281187ac1780f5a0

After:

$ l ~/.noisd/wasm/wasm/state/wasm/
b8cc8ae4201ee757a70c1e6d8b72c3afb94fc36ba95294ab0614011069de0fe5.wasm
cb7b021831dd908b673491288b7a76f7ae973b8c1586ce41d9a69cadab5202c7.wasm
ddaca2d1887555ebfe07a65ebec09fd3a159e78c3c429de9281187ac1780f5a0.wasm

To allow a smooth transition, the cache should store with .wasm file extension and try loading .wasm first and then without the .wasm. Ever new node and ever node that goes through state sync will only have the new format. The old format needs to be supported for a while to not disrupt long running machines.

@webmaster128 webmaster128 added this to the 1.3.0 milestone Apr 19, 2023
@chipshort chipshort self-assigned this May 5, 2023
chipshort added a commit that referenced this issue May 5, 2023
@webmaster128 webmaster128 mentioned this issue Jun 19, 2023
5 tasks
chipshort added a commit that referenced this issue Jun 21, 2023
@chipshort chipshort modified the milestones: 1.4.0, 1.3.0 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants