Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs (README): use via.placeholder.com for colors #93

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

almndbtr
Copy link
Contributor

Summary

Closes #92

This uses via.placeholder.com for colors in the syntax highlighting section of the README, updating "green" for #ccff00, the closest websafe color to #c5f015. For consistency, the inline CSS uses the specific hex color code to match rather than the previous strings (red, green).

Because both the GitHub.com README and the VS Code listing rely on this README file, this approach ensures that GitHub can render the color blocks appropriately and VS Code can apply the appropriate color to text.

@tintinweb tintinweb merged commit 517afed into Consensys:master Apr 14, 2022
@tintinweb
Copy link
Member

thanks @almndbtr 🤗

@tintinweb tintinweb added this to the v0.1.1 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs (README): images not found in Syntax Highlighting Section
2 participants