Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to references not working #119

Closed
faea726 opened this issue Nov 8, 2022 · 4 comments · Fixed by #125
Closed

go to references not working #119

faea726 opened this issue Nov 8, 2022 · 4 comments · Fixed by #125

Comments

@faea726
Copy link

faea726 commented Nov 8, 2022

It cannot go to references anymore.
It also prevents other extensions from doing that.

I'm using NomicFoundation.hardhat-solidity, it has go to references option, quite nice.
But whenever I enable tintinweb.solidity-visual-auditor, the go to references is not working anymore.
When I disable NomicFoundation.hardhat-solidity and only use tintinweb.solidity-visual-auditor, the go to references still not working.

=> I think it's caused by tintinweb.solidity-visual-auditor. Please have a check on that.

image

@tonisives
Copy link

tonisives commented Nov 10, 2022

I tried to use previous versions (0.1.3 and 0.1.2) and the references still didn't work. I also tried to use previous juanblanco.solidity, but still didn't help

edit: as a fix, you could disable auditor references with "solidity-va.findAllReferences.enable": false. Then vscode will use hardhat solidity references.

@faea726
Copy link
Author

faea726 commented Nov 10, 2022

I tried to use previous versions (0.1.3 and 0.1.2) and the references still didn't work. I also tried to use previous juanblanco.solidity, but still didn't help

edit: as a fix, you could disable auditor references with "solidity-va.findAllReferences.enable": false. Then vscode will use hardhat solidity references.

Work perfectly! Thanks for your suggestion.
But this is an user fix. So I will leave that issue open.

@jmhickman
Copy link

jmhickman commented Nov 16, 2022

I'm also experiencing this.

It coincided with my updating VSCode to 1.73.1. I rolled back my install to 1.72.x and it resumed working properly.

To add on: I'm not using any other solidity extensions, like hardhat or juanblanco's code. Only this extension.

@mlafon
Copy link

mlafon commented Nov 17, 2022

[error] TypeError: Class constructor d cannot be invoked without 'new'
    at .vscode/extensions/tintinweb.solidity-visual-auditor-0.1.4/src/features/references.js:63:19
    at Array.forEach (<anonymous>)
    at indicesToVscodeRange (.vscode/extensions/tintinweb.solidity-visual-auditor-0.1.4/src/features/references.js:42:13)
    at .vscode/extensions/tintinweb.solidity-visual-auditor-0.1.4/src/features/references.js:92:25
    at async Promise.all (index 1)
    at async .vscode/extensions/tintinweb.solidity-visual-auditor-0.1.4/src/features/references.js:86:21
    at async .vscode/extensions/tintinweb.solidity-visual-auditor-0.1.4/src/features/references.js:83:13

tintinweb added a commit that referenced this issue Jan 17, 2023
* prep v0.1.4

* properly instantiate vscode.location - fixes #119

* prepare v0.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants