Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExecutionRequestsDataCodec handling of missing request data #8880

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Dec 3, 2024

PR Description

Fixed Issue(s)

With recent changes in the execution requests, it is not valid to send an empty list for
a request type. So we should not accept an element with only a single byte as the
request type.

Thanks @jtraglia for finding this issue! :)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lucassaldanha lucassaldanha merged commit 88d23bc into Consensys:master Dec 3, 2024
17 checks passed
@lucassaldanha lucassaldanha deleted the fix-requests-codec branch December 3, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants