-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add post aggregate and proofs V2 API #8517
Merged
mehdi-aouadi
merged 5 commits into
Consensys:master
from
mehdi-aouadi:8439-aggregate-proof
Aug 22, 2024
Merged
add post aggregate and proofs V2 API #8517
mehdi-aouadi
merged 5 commits into
Consensys:master
from
mehdi-aouadi:8439-aggregate-proof
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request implements the new PostAggregateAndProofsV2 API to support EIP-7549 (Electra upgrade) while maintaining backward compatibility.
- Added new
PostAggregateAndProofsV2
endpoint in/data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/validator/PostAggregateAndProofsV2.java
- Modified
SignedAggregateAndProof
andAggregateAndProof
schemas in/ethereum/spec/src/main/java/tech/pegasys/teku/spec/datastructures/operations/
to support pre/post Electra configurations - Updated schema definitions in
/ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/
to accommodate Electra changes - Added integration tests for the new V2 API in
/data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v2/validator/PostAggregateAndProofsV2IntegrationTest.java
- Deprecated the V1 API in
/data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/validator/PostAggregateAndProofs.java
19 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
rolfyone
reviewed
Aug 20, 2024
...va/tech/pegasys/teku/beaconrestapi/v2/validator/PostAggregateAndProofsV2IntegrationTest.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Aug 20, 2024
...va/tech/pegasys/teku/beaconrestapi/v2/validator/PostAggregateAndProofsV2IntegrationTest.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Aug 20, 2024
...va/tech/pegasys/teku/beaconrestapi/v2/validator/PostAggregateAndProofsV2IntegrationTest.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Aug 20, 2024
...va/tech/pegasys/teku/beaconrestapi/v2/validator/PostAggregateAndProofsV2IntegrationTest.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Aug 20, 2024
.../src/main/java/tech/pegasys/teku/spec/datastructures/operations/SignedAggregateAndProof.java
Outdated
Show resolved
Hide resolved
rolfyone
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add PostAggregateAndProofsV2 API:
SignedAgrgegateAndProofs
andAggregateAndProofs
schemas to consider pre/post ElectraSchemaDefinitionCache
instead ofSchemaDefinition
in the old V1Fixed Issue(s)
fixes #8439
Documentation
doc-change-required
label to this PR if updates are required.Changelog