Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add post aggregate and proofs V2 API #8517

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Aug 20, 2024

PR Description

Add PostAggregateAndProofsV2 API:

  • Refactor the SignedAgrgegateAndProofs and AggregateAndProofs schemas to consider pre/post Electra
  • Use SchemaDefinitionCache instead of SchemaDefinition in the old V1
  • Deprecate the V1 API

Fixed Issue(s)

fixes #8439

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request implements the new PostAggregateAndProofsV2 API to support EIP-7549 (Electra upgrade) while maintaining backward compatibility.

  • Added new PostAggregateAndProofsV2 endpoint in /data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/validator/PostAggregateAndProofsV2.java
  • Modified SignedAggregateAndProof and AggregateAndProof schemas in /ethereum/spec/src/main/java/tech/pegasys/teku/spec/datastructures/operations/ to support pre/post Electra configurations
  • Updated schema definitions in /ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/ to accommodate Electra changes
  • Added integration tests for the new V2 API in /data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v2/validator/PostAggregateAndProofsV2IntegrationTest.java
  • Deprecated the V1 API in /data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/validator/PostAggregateAndProofs.java

19 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@mehdi-aouadi mehdi-aouadi self-assigned this Aug 20, 2024
@mehdi-aouadi mehdi-aouadi requested a review from rolfyone August 21, 2024 08:52
@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) August 22, 2024 12:09
@mehdi-aouadi mehdi-aouadi merged commit 933df84 into Consensys:master Aug 22, 2024
17 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 8439-aggregate-proof branch August 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beacon api] [electra] Add publishAggregateAndProofsV2 to support EIP-7549
2 participants