Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create deserializable type definition at each request #8538

Closed
mehdi-aouadi opened this issue Aug 27, 2024 · 1 comment · Fixed by #8544
Closed

Do not create deserializable type definition at each request #8538

mehdi-aouadi opened this issue Aug 27, 2024 · 1 comment · Fixed by #8544
Assignees

Comments

@mehdi-aouadi
Copy link
Contributor

Some type def client requests create the required deserializable type definition at each request (Examples: ProduceBlockRequest and SendAggregateAndProofsRequest).
This could be avoided by creating the deserializable type definition in advance and getting the correct one based on the request.

@rolfyone
Copy link
Contributor

This is an advantage of the old model where we didnt create an object per request. Ideally we can make use of SchemaDefinitionCache, or use the schema definitions from the request objects themselves... I'll have a quick look at the two listed.

@rolfyone rolfyone self-assigned this Aug 29, 2024
rolfyone added a commit to rolfyone/teku that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants