Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move p2p networking setting from Constants to SpecConfig #7179

Closed
lucassaldanha opened this issue May 25, 2023 · 1 comment
Closed

Move p2p networking setting from Constants to SpecConfig #7179

lucassaldanha opened this issue May 25, 2023 · 1 comment
Assignees
@zilm13

Comments

@lucassaldanha
Copy link
Member

Spec change: ethereum/consensus-specs#3375

P2P options will depend on chain configuration (e.g. Mainnet can have different values than Goerli).
@rolfyone rolfyone self-assigned this May 30, 2023
rolfyone added a commit to rolfyone/teku that referenced this issue May 31, 2023
@rolfyone
Moved gossip_max_size into out of constants into spec.
e59a405 
All of the move constants are in the mainnet.yaml and minimal.yaml, just that they are all disabled except for gossip_max_size. This will be the 'todo' list of Consensys#7179.

partially addresses Consensys#7179

Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone mentioned this issue May 31, 2023
Merged
2 tasks
rolfyone added a commit that referenced this issue Jun 1, 2023
@rolfyone
Moved gossip_max_size into out of constants into spec. (#7209)
e1a73d5 
All of the move constants are in the mainnet.yaml and minimal.yaml, just that they are all disabled except for gossip_max_size. This will be the 'todo' list of #7179.

partially addresses #7179

Signed-off-by: Paul Harris <[email protected]>
rolfyone added a commit to rolfyone/teku that referenced this issue Jun 1, 2023
@rolfyone
Fixed gossipMaxSize and maxChunkSize to use bellatrix derivitives and…
03f762c 
… be in presets properly.

partially addresses Consensys#7179

Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone mentioned this issue Jun 1, 2023
Merged
2 tasks
@zilm13 zilm13 mentioned this issue Jun 10, 2023
Closed
2 tasks
@rolfyone rolfyone assigned zilm13 and unassigned rolfyone Jun 14, 2023
@zilm13
Copy link
Contributor

zilm13 commented Jun 30, 2023

Resolved by #7250

@zilm13 zilm13 closed this as completed Jun 30, 2023
@siladu siladu mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zilm13 zilm13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use networking constants from the spec config zilm13/teku
3 participants
@lucassaldanha @rolfyone @zilm13