Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 👉 typescript #802

Merged
merged 14 commits into from
Jun 21, 2021
Merged

chore: 👉 typescript #802

merged 14 commits into from
Jun 21, 2021

Conversation

moshfeu
Copy link
Member

@moshfeu moshfeu commented Jun 14, 2021

part of #801

@moshfeu moshfeu marked this pull request as ready for review June 19, 2021 00:17
@moshfeu moshfeu requested a review from brentmclark June 20, 2021 20:37
@moshfeu
Copy link
Member Author

moshfeu commented Jun 20, 2021

@brentmclark I know it's a HUGE PR. I'll leave it open for a day. If you get a chance to take a look that will be great.
I've not finished but I want to merge so we could work on other tasks. We'll continue to migrate as we go.

@brentmclark
Copy link
Collaborator

@brentmclark I know it's a HUGE PR. I'll leave it open for a day. If you get a chance to take a look that will be great.
I've not finished but I want to merge so we could work on other tasks. We'll continue to migrate as we go.

@moshfeu It's unlikely I'll be able to give all 88 files a proper review. Any particular area I should focus on?

@moshfeu
Copy link
Member Author

moshfeu commented Jun 21, 2021

@brentmclark not particularly. Maybe you can give it not a deep attention just if something will jump out by a quick review.

@brentmclark
Copy link
Collaborator

With only a quick, superficial review everything seems in order. Great work Mosh!

@moshfeu moshfeu merged commit 4838492 into master Jun 21, 2021
@moshfeu moshfeu deleted the typescript branch June 21, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants