This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
This sassy commit is all the rage this summer. #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves Code52#192 - introduces Sass for CSS generation. Uses Libsassnet to provide the Sassyness. Switches out ILMerge for Fody/Costura. When handling unmanaged assemblies, this is the best solution. This required some modifications to how MEF was used. It uses a very specific version of Fody/Costura because of issues with VS15, I think. Please don't update it.
|
This should probably also remove ilmerge.exe |
|
This is also obviously not going to work with mono, since its a native binary for the Windahs Operatung Sostem. Is there any entirely MSIL version of Sass? |
|
Even if it does not work on mono, it should be implemented that if this feature is not used on mono, other features are not affected. IMHO it would also be nice if the user would be informed about this fact in an informative message instead of a cryptic stacktrace. (I'm not an experienced DllImport user, so I don't know if this is true for the current state) |
|
Thanks for the PR, it looks good.
|
|
Just saw this. Nope nope and away! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #192 - introduces Sass for CSS generation. Uses Libsassnet to provide the Sassyness.
Switches out ILMerge for Fody/Costura. When handling unmanaged assemblies, this is the best solution. This required some modifications to how MEF was used.
It uses a very specific version of Fody/Costura because of issues with VS15, I think. Please don't update it.