Add superweapon selector window and superweapon ID param type #177
+134
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZivDero
reviewed
Jun 12, 2024
| if (swType == null) | ||
| return paramValue; | ||
|
|
||
| return swType.GetDisplayStringWithoutIndex(); |
There was a problem hiding this comment.
How about just .ToString()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes superweapon parameter for trigger events & actions to use the window-based selector, as most YR projects tend to have much larger selection of superweapons available which exceeds what the context menu can comfortably show. I was initially going to make this optional and have default behaviour use the context menu still, but I figured that might make the code unnecessarily complicated. If that is preferrable however, I can make it happen.
Additionally added support for superweapon ID (section name) as a parameter type, which is used by one trigger event added by Ares.