-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow certain ALTER TABLE commands for plain_rewritable
disk
#63933
Allow certain ALTER TABLE commands for plain_rewritable
disk
#63933
Conversation
Currently all alters are disallowed, this is too restrictive. Allow altering settings (through {MODIFY|RESET} SETTING) and comments (MODIFY COMMENT).
plain_rewritable
plain_rewritable
disk
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: More than one changelog category specified: 'Bug Fix (user-visible misbehavior in an official stable release)', 'CI Fix or Improvement (changelog entry is not required)' |
This is an automated comment for commit 81a7862 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
4021e9a
Currently, all alters are disallowed. This may be too restrictive for some use cases. Allow 'non-replicated' alter commands:
MODIFY|RESET SETTING
andMODIFY COMMENT
.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow
ALTER TABLE .. MODIFY|RESET SETTING
andALTER TABLE .. MODIFY COMMENT
for plain_rewritable disk.Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: