-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental KQL: Clickhouse server v24.1.1.1 SEGV
inside DB::(anonymous namespace)::writeQueryAroundTheError
#59037
Comments
SEGV
inside DB::(anonymous namespace)::writeQueryAroundTheError
SEGV
inside DB::(anonymous namespace)::writeQueryAroundTheError
The deadline to fix is one month (Mar 1st, 2024) - if it will not be fixed, we will remove the experimental KQL altogether. |
@kashwy is working on it |
Hi @hnlcf , how did you run The SQL statement line by line in file [poc-2.sql] ? there are so many lines. looks like you did debugging , were you debugging the clickhouse-client ? |
This commit fix the issues: ClickHouse#59036 ClickHouse#59037 both issues are same reason, the input query exceed the max_query_size, so the condition isEnd() of token is not meet and cause the assertion failure
can you do the WINGFUZZ again ? thanks |
Here I also cannot reproduce the crash. |
Does not reproduce. |
… `max_query_size` (#59626) * Fix_kql_issue_found_by_wingfuzz This commit fix the issues: #59036 #59037 both issues are same reason, the input query exceed the max_query_size, so the condition isEnd() of token is not meet and cause the assertion failure * fix_kql_issue_found_by_wingfuzz: use isValid instead of TokenType::EndOfStream * fix_kql_issue_found_by_wingfuzz: make functional test result consist * fix_kql_issue_found_by_wingfuzz: update test case for makeseries * fix_kql_issue_found_by_wingfuzz: disable makeseries * fix_kql_issue_found_by_wingfuzz: use isvalid() function to replace isEnd() function of TokenIterator to check the end of stream * fix_kql_issue_found_by_wingfuzz: add test case for max_query_size * fix_kql_issue_found_by_wingfuzz: fix AST structure * fix_kql_issue_found_by_wingfuzz: make sure the max query size test is in the dialect of kusto * fix_kql_issue_found_by_wingfuzz : restore max query size after test * fix_kql_issue_found_by_wingfuzz : fix typo --------- Co-authored-by: János Benjamin Antal <[email protected]>
Describe the bug
ClickHouse server version 24.1.1.1 received SIGSEGV signal
It was found by an in-development fuzzer of WINGFUZZ.
How to reproduce
The SQL statement to reproduce (it is need to execute line by line): poc-2.sql
Stacktrace
Server log
The text was updated successfully, but these errors were encountered: