Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: passing personalisation to overlay #267

Merged
merged 21 commits into from
Oct 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3585206
feat: passing personalisation to overlay
kkyusuftk Sep 23, 2024
5afed6a
renoved unnecessary changes
kkyusuftk Sep 23, 2024
818e620
Merge branch 'master' of github.com:CleverTap/clevertap-web-sdk into …
kkyusuftk Sep 26, 2024
a66eb1b
fix: removed isshopify as an argument
kkyusuftk Sep 26, 2024
f991fcf
added changes for preview
AshwinSaxena01 Oct 8, 2024
90fbe99
Merge remote-tracking branch 'origin/visual-editor-payload' into WEB-…
AshwinSaxena01 Oct 10, 2024
e0a86dc
added preview flag
AshwinSaxena01 Oct 10, 2024
5b6be2c
updated text render key for delivery
AshwinSaxena01 Oct 10, 2024
ef3f2d0
Updated build files
KambleSonam Oct 10, 2024
41a9a90
Merge branch 'develop' into WEB-3204
AshwinSaxena01 Oct 18, 2024
99cce0c
updated build files
AshwinSaxena01 Oct 18, 2024
126edb8
Merge branch 'WEB-3204' of https://github.com/CleverTap/clevertap-web…
AshwinSaxena01 Oct 18, 2024
dc0b344
Merge branch 'develop' of https://github.com/CleverTap/clevertap-web-…
AshwinSaxena01 Oct 22, 2024
b1ba9f4
updated build files
AshwinSaxena01 Oct 22, 2024
e8f8d43
Merge branch 'master' of https://github.com/CleverTap/clevertap-web-s…
AshwinSaxena01 Oct 22, 2024
59b1d9c
staging overlay path
AshwinSaxena01 Oct 22, 2024
77a4f2c
added overlay production
AshwinSaxena01 Oct 24, 2024
9f6cfb2
removed console
AshwinSaxena01 Oct 24, 2024
e75c042
merging with develop
kkyusuftk Oct 24, 2024
f20841b
updated version and changelog
kkyusuftk Oct 30, 2024
ef315f3
Update CHANGELOG.md
kkyusuftk Oct 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added preview flag
AshwinSaxena01 committed Oct 10, 2024

Verified

This commit was signed with the committer’s verified signature.
SimonBrandner Šimon Brandner
commit e0a86dc880667a642a2ca23d6fd147cb9f93d02a
47 changes: 26 additions & 21 deletions clevertap.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion clevertap.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion clevertap.min.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/modules/visualBuilder/dataUpdate.js
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ export const updateFormData = (element, formStyle, isPreview) => {

// Update element text
if (formStyle.text !== undefined) {
console.log(formStyle.text)
element.innerText = isPreview ? formStyle.text.text : formStyle.text.replacements
}

2 changes: 1 addition & 1 deletion src/modules/visualBuilder/pageBuilder.js
Original file line number Diff line number Diff line change
@@ -165,7 +165,7 @@ export const renderVisualBuilder = (targetingMsgJson, isPreview) => {
} else if (selector.values?.json) {
dispatchJsonData(targetingMsgJson, selector.values)
} else {
updateFormData(element, selector.values.form)
updateFormData(element, selector.values.form, isPreview)
}
}